Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing upload of parties.conf #29

Closed
wants to merge 1 commit into from

Conversation

lenerd
Copy link
Contributor

@lenerd lenerd commented Oct 10, 2018

This readds the lines lost in ef6ef8a. See #24 (comment).

I am not completely sure about the len(regions) > 1 case and have not tested that.

@liorko87
Copy link
Contributor

Fixed at #24

@liorko87 liorko87 closed this Oct 23, 2018
@lenerd
Copy link
Contributor Author

lenerd commented Oct 26, 2018

Hi Lior,

Fixed at #24

I am not sure what you are referring to. The upload of the parties.conf is still missing in the external case without a coordinator:

MATRIX/Execution/fabfile.py

Lines 120 to 124 in 776522c

else:
# run external protocols with no coordinator
run('. ./%s %s %s' % (executable_name, party_id, values_str))
with open('Execution/execution_log.log', 'a+') as log_file:
log_file.write('%s\n' % values_str)

I have updated the branch of this PR w.r.t. 9a7d5af.

@liorko87
Copy link
Contributor

Hi Lennart,

I uploaded this line again, it's probably deleted by mistake.

Lior

@lenerd
Copy link
Contributor Author

lenerd commented Oct 31, 2018

Hi,
unfortunately, this is still broken for the multi-region case:
Compare this (external with coordinator)

MATRIX/Execution/fabfile.py

Lines 112 to 116 in e343af1

if len(regions) > 1:
put('InstancesConfigurations/parties%s.conf' % party_id, run('pwd'))
run('mv parties%s.conf parties.conf' % party_id)
else:
put('InstancesConfigurations/parties.conf', run('pwd'))

with this (external without coordinator)

MATRIX/Execution/fabfile.py

Lines 123 to 124 in e343af1

put('InstancesConfigurations/parties.conf', run('pwd'))
run('mkdir -p logs')

@liorko87
Copy link
Contributor

liorko87 commented Nov 4, 2018

Hi,
When using the multi-region case, each server(instance) has it's own parties file (line 113).
That's the reason why we added the party_id to each file.
Afterwards at line 114 we are changing it to it's original name.

@lenerd
Copy link
Contributor Author

lenerd commented Nov 4, 2018

Hi Lior,

I understand that. The problem is that these lines are missing for the case of an external protocol without a coordinator. In that case, every party gets the same configuration file whether multiple regions are used or not (line 123).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants