-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix missing upload of parties.conf #29
Conversation
These lines got lost in ef6ef8a.
Fixed at #24 |
Hi Lior,
I am not sure what you are referring to. The upload of the Lines 120 to 124 in 776522c
I have updated the branch of this PR w.r.t. 9a7d5af. |
Hi Lennart, I uploaded this line again, it's probably deleted by mistake. Lior |
Hi, Lines 112 to 116 in e343af1
with this (external without coordinator) Lines 123 to 124 in e343af1
|
Hi, |
Hi Lior, I understand that. The problem is that these lines are missing for the case of an external protocol without a coordinator. In that case, every party gets the same configuration file whether multiple regions are used or not (line 123). |
This readds the lines lost in ef6ef8a. See #24 (comment).
I am not completely sure about the
len(regions) > 1
case and have not tested that.