Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Dash info #13

Merged
merged 1 commit into from
Jan 7, 2016
Merged

update Dash info #13

merged 1 commit into from
Jan 7, 2016

Conversation

UdjinM6
Copy link
Contributor

@UdjinM6 UdjinM6 commented Jan 6, 2016

  • update mainnet to use hex values (to follow btc style)
  • fix testnet params

@UdjinM6 UdjinM6 mentioned this pull request Jan 6, 2016
Closed
@jprichardson
Copy link
Member

When did this change happen?

@UdjinM6
Copy link
Contributor Author

UdjinM6 commented Jan 6, 2016

Err.. Which one? Testnet params here are broken now for some reason and I just modified them to use correct values... https://github.com/dashpay/dash/blob/master/src/chainparams.cpp#L237-L241

jprichardson added a commit that referenced this pull request Jan 7, 2016
@jprichardson
Merge pull request #13 from UdjinM6/dash
46a4bbd 
update Dash info
@jprichardson jprichardson merged commit 46a4bbd into cryptocoinjs:master Jan 7, 2016
@gpip
Copy link

gpip commented Mar 18, 2017

Maybe I'm misreading this but shouldn't the pubkey addr byte be 0x8c (140) instead of 0x8b (139)?

@UdjinM6
Copy link
Contributor Author

UdjinM6 commented Mar 18, 2017

@gpip yep, testnet pubkey version changed in 12.1 release. #28 should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UdjinM6 @jprichardson @gpip