Fix HDKey.sign method arguments types

[DDushkin]

secp256k1.ecdsaSign() expects Uint8Arrays as arguments instead of Buffers

[RyanZim]

Buffer is a subclass of Uint8Array, so buffer instanceof Uint8Array === true. There's no point in casting it here.

[DDushkin]

Buffer is a subclass of Uint8Array, so buffer instanceof Uint8Array === true. There's no point in casting it here.

Yeah, I understand but I introduced this because I got such error on hdkey.sign()
[Error: Expected private key to be an Uint8Array]
And it also mimics the hdkey.verify() method, which already contains Uint8Array.from()

hdkey/lib/hdkey.js

Line 163 in be098e4

Uint8Array.from(this.publicKey)

[junderw]

Some front ends have Buffer polyfills that are not subclass of Uint8Array

[DDushkin]

Some front ends have Buffer polyfills that are not subclass of Uint8Array

I'm on React Native, using rn-nodeify and shim like this

if (typeof Buffer === "undefined") global.Buffer = require("buffer").Buffer;

[RyanZim]

Some front ends have Buffer polyfills that are not subclass of Uint8Array

Was not aware of this; in that case, not opposed to the change; @junderw feel free to merge