Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (prebuilds) Fix issue where prebuilds were not being fetched correc… #259

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

dillionverma
Copy link

Linked Issue

Overview

  • After testing building locally, we discovered that prebuilt binaries are not fetched for every release including 0.3.11 and beyond. Seems like there was a change introduced v0.3.10...v0.3.11 which prevented that.
  • Reverted one of the commits to ensure binaries are fetched correctly
  • Tested locally and prebuilt binaries were fetched correctly!

How to use

Items reserved this time, or TODO

Check list

** Person who issued **

  • checked script
  • build successed
  • Linked PullRequest and Issue

** Reviewer **

  • (if necessary) Record the review results of related tickets.

Memo

@k-matsuzawa
Copy link
Collaborator

@dillionverma
Thanks!
After merging this, bump and release. 🙏

The reason I changed from got to needle was because got became typescript only, but I guess I could try to use ts-node. I will modify this area separately. 🙇‍♂️

@k-matsuzawa k-matsuzawa merged commit 1da9199 into cryptogarageinc:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants