Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 build: Update CXX standard to 14 #36

Merged

Conversation

dillionverma
Copy link

@dillionverma dillionverma commented May 19, 2022

What?

Bump CXX standard to c++ 14 for libwally.

Why?

As of right now, cfd-dlc-js builds perfectly fine on node v14. However, when attempting to build node.js projects with cfd-dlc-js on node v16, the compilation fails with a very similar error message to the one described here:
nodejs/node#38367

 error: no template named 'remove_cv_t' in namespace 'std'; did you mean 'remove_cv'?
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
                                ~~~~~^~~~~~~~~~~
                                     remove_cv

Digging deeper, I discovered that if I set CXX version of libwally (which is a dependency of cfd-dlc-js) to 14, then everything builds successfully on nodejs v16.

@k-matsuzawa
Copy link

@dillionverma
Thanks!
I think we need to release all of them, so we will release them one by one.
(libwally-core, cfd-core, cfd, cfd-js)

@k-matsuzawa k-matsuzawa merged commit ed58165 into cryptogarageinc:cfd-develop May 20, 2022
@k-matsuzawa
Copy link

@dillionverma
I have released all of them. Use these:

  • cfd-js: v0.4.5
  • cfd: v0.4.5
  • cfd-core: v0.4.4
  • libwally-core: cfd-0.4.7

@dillionverma
Copy link
Author

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants