Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Bump CXX standard to c++ 14 for libwally.
Why?
As of right now, cfd-dlc-js builds perfectly fine on node v14. However, when attempting to build node.js projects with cfd-dlc-js on node v16, the compilation fails with a very similar error message to the one described here:
nodejs/node#38367
Digging deeper, I discovered that if I set CXX version of libwally (which is a dependency of cfd-dlc-js) to 14, then everything builds successfully on nodejs v16.