Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated element in table of content (TOC) #1336

Closed
ghost opened this issue Dec 11, 2023 · 0 comments · Fixed by #1392
Closed

Duplicated element in table of content (TOC) #1336

ghost opened this issue Dec 11, 2023 · 0 comments · Fixed by #1392
Assignees
@Chouhartem
Labels
Bug There is a problem in our source code Fixed in staging This is live on staging branch Rich Text Related to the Rich Text app

Comments

@ghost
Copy link

ghost commented Dec 11, 2023

Description

The table of content (TOC) is repeating some parts for no apparent reason

image

Steps to reproduce

  1. Create a Rich Text document
  2. Fill it up with content
  3. Respect the heading order
  4. Witness this duplicate entry in the table of content

Relevant logs

No response

Expected behavior

There should be no duplicated elements in the table of content.

What opreating system are you using?

Linux/BSD/UNIX, Microsoft Windows, Apple macOS

What browsers are you seeing the problem on?

Mozilla Firefox, Google Chrome, Apple Safari

Extensions

Not relevant

Version

5.5.0
@ghost ghost added Bug There is a problem in our source code Rich Text Related to the Rich Text app labels Dec 11, 2023
@ghost ghost modified the milestone: 5.6.0 Dec 11, 2023
@ghost ghost added this to 5.6.0 Dec 11, 2023
@ghost ghost moved this to Todo in 5.6.0 Dec 11, 2023
@ghost ghost removed this from 5.6.0 Dec 18, 2023
@Chouhartem Chouhartem self-assigned this Jan 15, 2024
Chouhartem added a commit that referenced this issue Jan 17, 2024
@Chouhartem
#1336: filter out temporary information with diffDOM
e92c82a 
- The issue was caused by the way ckeditor manages clipboard, creating
  some chunk inside a data-cke-temp span or div depending on the size
  (which are sometimes empty… or containing ` `), we filter them
  before sending data to storage. It fixes the duplicated TOC elements
  issue.
Chouhartem added a commit that referenced this issue Jan 18, 2024
@Chouhartem
#1358: restore table editing in pads as default configuration
7ba6d1b 
- Restore context menu as table editing menu depends on it. It has been
  removed with commit 7f35840
- The paste button appears to still be there on mobile (Fennec fdroid on
  android 9)
- #1336: missing closing parenthesis in a comment

Note that you can add it to your instance configuration with the
`customize/` directory: https://docs.cryptpad.org/en/admin_guide/customization.html
@Chouhartem Chouhartem mentioned this issue Jan 24, 2024
Merged
yflory added a commit that referenced this issue Jan 29, 2024
@yflory
Merge pull request #1392 from cryptpad/fix-richtext-issues
8b0cc52 
Fix richtext issues (#1336 + ~#1358 + #1226)
@Chouhartem Chouhartem added the Fixed in staging This is live on staging branch label Jan 30, 2024
@Chouhartem Chouhartem linked a pull request Jan 30, 2024 that will close this issue
Fix richtext issues (#1336 + ~#1358 + #1226) #1392
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chouhartem Chouhartem

Labels
Bug There is a problem in our source code Fixed in staging This is live on staging branch Rich Text Related to the Rich Text app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix richtext issues (#1336 + ~#1358 + #1226) cryptpad/cryptpad
2 participants
@Chouhartem @davidbenque