Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make performance table responsive for mobile #1555

Merged
merged 11 commits into from
Aug 28, 2024
Merged

Make performance table responsive for mobile #1555

merged 11 commits into from
Aug 28, 2024

Conversation

DianaXWiki
Copy link
Contributor

No description provided.

@DianaXWiki DianaXWiki requested a review from yflory July 11, 2024 10:09
@DianaXWiki DianaXWiki added this to the Autumn release (2024.9.0) milestone Jul 11, 2024
@davidbenque davidbenque requested review from davidbenque and removed request for yflory July 16, 2024 10:21
@davidbenque
Copy link
Contributor

Addressing #1099

@DianaXWiki DianaXWiki changed the title 1099 performance table not responsive for mobile Make performance table not responsive for mobile Jul 16, 2024
@DianaXWiki DianaXWiki changed the title Make performance table not responsive for mobile Make performance table responsive for mobile Jul 16, 2024
@DianaXWiki DianaXWiki added the Ready to Review This PR is ready to be checked by another team member label Jul 17, 2024
davidbenque
davidbenque requested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@davidbenque davidbenque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about the code. Otherwise the table layout seems to work well, please generalize it to all tables in the admin app

www/admin/inner.js Outdated Show resolved Hide resolved
www/admin/app-admin.less Outdated Show resolved Hide resolved
www/admin/inner.js Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
@davidbenque davidbenque removed the Ready to Review This PR is ready to be checked by another team member label Jul 18, 2024
@DianaXWiki DianaXWiki added the Ready to Review This PR is ready to be checked by another team member label Jul 23, 2024
@davidbenque
Copy link
Contributor

This looks good, all issues seem addressed. Remaining question is about code organisation, right now we have:

  • .cp-sidebar-table in sidebar-layout.less
  • #cp-admin-table in app-admin.less
    But these are always used together and it seems like we would want any new tables in a sidebar-layout to benefit from the horizontal scrolling on mobile. So before merging we should check where this code should be and potentially bring all table styles to sidebar-layout.less

davidbenque
davidbenque reviewed Jul 30, 2024
View reviewed changes
.eslintrc.js Outdated Show resolved Hide resolved
@davidbenque davidbenque added Ready to Test This PR is ready to be tested and removed Ready to Review This PR is ready to be checked by another team member labels Jul 30, 2024
@yflory yflory merged commit 29433c7 into staging Aug 28, 2024
@davidbenque davidbenque removed the Ready to Test This PR is ready to be tested label Dec 6, 2024
@mathilde-cryptpad mathilde-cryptpad deleted the 1099-performance-table-not-responsive-for-mobile branch December 18, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbenque davidbenque davidbenque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Autumn release (2024.9.0)
Development

Successfully merging this pull request may close these issues.
3 participants
@DianaXWiki @davidbenque @yflory