cache: fix most failing WPTs (nodejs#2100)

crysmags · Feb 27, 2024 · 048fcda · 048fcda
1 parent 63fcb71
commit 048fcda
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 32 deletions.
diff --git a/lib/cache/cache.js b/lib/cache/cache.js
@@ -575,7 +575,7 @@ class Cache {
   }
 
   /**
-   * @see https://w3c.github.io/ServiceWorker/#batch-cache-operations
+   * @see https://w3c.github.io/ServiceWorker/#batch-cache-operations-algorithm
    * @param {CacheBatchOperation[]} operations
    * @returns {requestResponseList}
    */
@@ -746,11 +746,9 @@ class Cache {
     //   return false
     // }
 
-    /** @type {URL} */
-    const queryURL = requestQuery.url
+    const queryURL = new URL(requestQuery.url)
 
-    /** @type {URL} */
-    const cachedURL = request.url
+    const cachedURL = new URL(request.url)
 
     if (options?.ignoreSearch) {
       cachedURL.search = ''

diff --git a/test/wpt/status/service-workers/cache-storage.status.json b/test/wpt/status/service-workers/cache-storage.status.json
@@ -11,38 +11,13 @@
       "note": "probably can be fixed",
       "fail": [
         "Cache.put with a VARY:* opaque response should not reject",
-        "Cache.put with opaque-filtered HTTP 206 response",
-        "Cache.put with a relative URL"
+        "Cache.put with opaque-filtered HTTP 206 response"
       ]
     },
     "cache-match.https.any.js": {
       "note": "requires https server",
       "fail": [
-        "cors-exposed header should be stored correctly.",
-        "Cache.match ignores vary headers on opaque response."
-      ]
-    },
-    "cache-delete.https.any.js": {
-      "note": "spec bug? - https://github.com/w3c/ServiceWorker/issues/1677 (first fail)",
-      "fail": [
-        "Cache.delete with ignoreSearch option (when it is specified as false)"
-      ]
-    },
-    "cache-keys.https.any.js": {
-      "note": "probably can be fixed",
-      "fail": [
-        "Cache.keys with ignoreSearch option (request with search parameters)",
-        "Cache.keys without parameters",
-        "Cache.keys with explicitly undefined request"
-      ]
-    },
-    "cache-matchAll.https.any.js": {
-      "note": "probably can be fixed",
-      "fail": [
-        "Cache.matchAll with ignoreSearch option (request with search parameters)",
-        "Cache.matchAll without parameters",
-        "Cache.matchAll with explicitly undefined request",
-        "Cache.matchAll with explicitly undefined request and empty options"
+        "cors-exposed header should be stored correctly."
       ]
     }
   }