Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull solve_item_traits out of mir_traits #637

Closed
W95Psp opened this issue Apr 29, 2024 · 4 comments
Closed

Pull solve_item_traits out of mir_traits #637

W95Psp opened this issue Apr 29, 2024 · 4 comments
Assignees
Labels
frontend Issue in the Rust to JSON translation

Comments

@W95Psp
Copy link
Collaborator

W95Psp commented Apr 29, 2024

#627 introduces a use of mir_traits::solve_item_traits in the extraction of types, which are common to THIR and MIR. Thus solve_item_traits should move out of mir_traits.rs.

solve_item_traits should anyway be re-written using the traits rustc_utils::SubstBinder and rustc_utils::PredicateToPolyTraitRef.

@W95Psp W95Psp added the frontend Issue in the Rust to JSON translation label Apr 29, 2024
@Nadrieril Nadrieril self-assigned this May 6, 2024
Copy link

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Aug 28, 2024
@W95Psp
Copy link
Collaborator Author

W95Psp commented Aug 28, 2024

@github-actions github-actions bot removed the stale label Aug 29, 2024
Copy link

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Oct 28, 2024
@W95Psp
Copy link
Collaborator Author

W95Psp commented Oct 28, 2024

@Nadrieril fixed that in #1031 :)

@W95Psp W95Psp closed this as completed Oct 28, 2024
@W95Psp W95Psp removed the stale label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issue in the Rust to JSON translation
Projects
None yet
Development

No branches or pull requests

2 participants