Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues my work in cleaning up trait resolution. Of particular importance is the clarification of "required" vs "implied" predicates: required predicates must be proven to mention an item (e.g. one must prove
T: Sized
to mentionOption<T>
) whereas implied predicates are implied by the item being present in a signature (e.g.T: Copy
impliesT: Clone
).So far we consider all predicates on a trait declaration to be implied, but that's not what rustc does. For example:
Here (according to rustc)
T: Clone
is required to mentionFoo
, andSelf: ToString
is implied bySelf: Foo
. I don't know if consideringT: Clone
as implied (like we implicitly did today) could cause problems but at least now what's happening is clear.