Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include bodies in FullDef #1055

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Include bodies in FullDef #1055

merged 4 commits into from
Oct 28, 2024

Conversation

Nadrieril
Copy link
Collaborator

So that we can start using FullDef instead of hir::ItemKind.

@Nadrieril Nadrieril requested a review from W95Psp October 28, 2024 15:44
W95Psp
W95Psp approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you!
Will try to migrate import_thir when I have some time!

@Nadrieril Nadrieril added this pull request to the merge queue Oct 28, 2024
Merged via the queue into cryspen:main with commit 381bd0f Oct 28, 2024
14 checks passed
@Nadrieril Nadrieril deleted the generic-fulldef branch October 28, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W95Psp W95Psp W95Psp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nadrieril @W95Psp