-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make verified ML-KEM available in libcrux-ml-kem
#329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for the code updates, please re-request review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a few nits and one bigger issue below.
Looks like I didn't feature guard tests, example etc. in #333. Now things fail when running without default features.
You can run cargo hack test --each-feature
(excluding things like simd128
on x64 machines with --exclude-features
) to see what happens. In particular cargo test --no-default-features
seems to fail already. We should get that on CI.
So broken combinations are at least
- --no-default-features
- --no-default-features --features kyber
Especially the second one should work.
But we can do that in a follow up if you want.
I added more feature gates, so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a pass and fixed all the remaining issues (that I found, there may be more).
I also added more docs and regenerated F* and C code. I think this is good to go.
This PR integrates the version of ML-KEM into
libcrux-ml-kem
that was verified and previously lived in thekem
module oflibcrux
. I've also introduced apre-verification
feature gate inlibcrux-ml-kem
andlibcrux-kem
for code that is not verified, yet.Fixes #326