Fix big-endian support in cg #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschneider-bensch
previously requested changes
Nov 4, 2024
Co-authored-by: Jonas Schneider-Bensch <124457079+jschneider-bensch@users.noreply.github.com>
github-actions
bot
dismissed
jschneider-bensch’s stale review
Review re-requested
jschneider-bensch
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C code in the cg directory was minimal and dropped all the endianness support.
This PR also disables benchmarks by default for the C code. They can be enabled with
LIBCRUX_BENCHMARKS=1.Fixes #643