Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix portable variable assignments in Makefile #478

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Fix portable variable assignments in Makefile #478

merged 2 commits into from
Oct 11, 2024

Conversation

straight-shoota
Copy link
Contributor

Resolves #477

@straight-shoota
Copy link
Contributor Author

straight-shoota commented Oct 10, 2024 •
edited
Loading

I'd also suggest using make in CI to remove duplication and have an integration test for the build system.
And could we please remove the branches: [master] restriction from the CI workflow? It prevents CI from running on feature branches and you need extra hassle to make it work.

Sija
Sija reviewed Oct 10, 2024
View reviewed changes
@Sija Sija added this to the 1.6.3 milestone Oct 10, 2024
@Sija
Copy link
Member

Sija commented Oct 11, 2024

I'd also suggest using make in CI to remove duplication and have an integration test for the build system.

Good point.

And could we please remove the branches: [master] restriction from the CI workflow? It prevents CI from running on feature branches and you need extra hassle to make it work.

Why not open a (draft) PR?

@Sija Sija merged commit dce8a2c into crystal-ameba:master Oct 11, 2024
4 checks passed
@Sija Sija changed the title Fix portable variable assignments in Makefile Fix portable variable assignments in Makefile Oct 11, 2024
@Sija Sija mentioned this pull request Oct 11, 2024
Merged
@straight-shoota straight-shoota deleted the infra/Makefile-portable branch October 11, 2024 07:34
@Sija Sija linked an issue Oct 12, 2024 that may be closed by this pull request
Installation fails Errno::ENOENT: No such file or directory - bin/ameba crystal-ameba/homebrew-ameba#1
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija approved these changes

Assignees

@straight-shoota straight-shoota

Labels
bug infrastructure
Projects
None yet
Milestone
1.6.3
Development

Successfully merging this pull request may close these issues.

Installation fails Errno::ENOENT: No such file or directory - bin/ameba Q: I can't build ameba with make
2 participants
@straight-shoota @Sija