Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate 'no parlo inglese' in German #41

Merged
merged 2 commits into from
Oct 13, 2019

Conversation

danrocha
Copy link
Contributor

@danrocha danrocha commented Oct 4, 2019

Contributes to #3

Added German translation.
Not sure if I should also add the Austrian and Swiss flags?

@davcri
Copy link
Member

davcri commented Oct 5, 2019

That's a good question. I would say yes, let's be inclusive 😄 I'll merge the PR immediately afterwards!

Thank you for your contribution! And happy Hacktoberfest 🎉

@danrocha
Copy link
Contributor Author

danrocha commented Oct 5, 2019

I went on and added all the flags of all countries with German as their official language (Austria, Germany, Liechtenstein, Belgium, Switzerland, Luxembourg).

But I am not sure about this though. If you follow this pattern and look at Spanish, for example, the list of flags would be pretty long.

What do you think?

@davcri
Copy link
Member

davcri commented Oct 5, 2019

@danrocha you are right, some language is adopted by many countries. I think a good approach is:

If the language is spoken in more than 3 countries we put the 3 most common nations as a flag and then we add:

🇪🇸 🇦🇷 🇲🇽 (... and all the other countries where people speak Spanish): ...

Maybe we could also add a text at the beginning of the list saying something like:

⚠️ NOTE: If you don't see a flag representing your nation, I'm really sorry for this. We decided to put 3 flags at max for each language for practical reasons. Feel free to say your opinion and leave a comment here,

@davcri
Copy link
Member

davcri commented Oct 13, 2019

@danrocha I'm gonna accept this PR, we can discuss further if needed! Thanks for your help!

@davcri davcri merged commit a669b6b into crystal-bit:master Oct 13, 2019
@danrocha
Copy link
Contributor Author

@davcri sorry for the delay in replying, I was out traveling with family!

Another solution would be to replace the country flags with the iso code for the language.
de
es
en

what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants