Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Crystal 0.35.0 #33

Closed
wants to merge 1 commit into from
Closed

Fix for Crystal 0.35.0 #33

wants to merge 1 commit into from

Conversation

jamescook
Copy link
Contributor

@jamescook jamescook commented Jun 12, 2020 •
edited
Loading

I ran into the below error until I updated the dependencies.

06:31 $ crystal spec
Showing last frame. Use --error-trace for full trace.

In /usr/local/Cellar/crystal/0.35.0/src/io.cr:845:34

 845 | def write_byte(byte : UInt8) : Int64
                                      ^
Error: method must return Int64 but it is returning (Int64 | Nil)

spider-gazelle/openssl_ext@v1.2.0...stakach:v1.2.1
spider-gazelle/bindata@v1.5.3...v1.5.4

More background: crystal-lang/crystal#9454

@bcardiff bcardiff mentioned this pull request Jun 12, 2020
Merged
@xaviablaza
Copy link

Hello, could we please merge this into the upstream?

@jamescook
Copy link
Contributor Author

Crystal 0.35.1 reverted the change to IO#write that is causing errors. I don't think this PR is needed anymore.

@xaviablaza
Copy link

Agree, this is no longer needed -- the dependencies have also been updated to reflect the reverted changes.

@jamescook jamescook closed this Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamescook @xaviablaza