Add support for using keywords in type declarations #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keidax
requested changes
Dec 31, 2024
There was a problem hiding this comment.
I don't think this is the right way to go. It adds a lot of complexity to the scanner for relatively little gain.
I hope this is something we can resolve without needing the scanner at all. Have you looked at the reserved feature at all? You could also investigate how tree-sitter-javascript accomplishes this.
|
Testing out the reserved feature, can't seem to get it to work, don't know what I'm doing wrong. Will look into this in a few days. 
|
|
Blocked by next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39