Release 0.9.2 #189
Merged
Release 0.9.2 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nobodywasishere
commented
Feb 20, 2024
nobodywasishere
commented
- Add highlighting for built-in spec keywords (Syntax highlight mismatch for methods and variables #186)
- Add keywords to autocomplete (do autocompletes to DivisionByZero on ENTER #187)
- Don't highlight method calls as unused (Non-variables starting with underscore are colored like comments #188)
wJoenn
reviewed
Feb 20, 2024
Comment on lines
+141
to
+145
| { | ||
| "comment": "everything being a spec keyword, not a value, and needing a block is a..", | ||
| "match": "(?<!\\.)\\b(describe|context|it|expect_raises)\\b(?![?!:])", | ||
| "name": "keyword.control.crystal" | ||
| }, |
There was a problem hiding this comment.
Was it intentional not to mark every spec related methods like should, be_true, eq etc as a "method" equivalent ?
There was a problem hiding this comment.
Yes, I didn't think it was necessary and potentially cause for confusion as those method names are likely to exist outside of the spec context. I also wanted the spec highlighting to be consistent with other highlighting (i.e., there aren't any other method calls that are highlighted without parenthesis)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.