Improve DB::MappingException usage #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
reviewed
Sep 14, 2020
| @@ -3,6 +3,19 @@ module DB | |||
| end | |||
|
|
|||
| class MappingException < Error | |||
| getter klass | |||
There was a problem hiding this comment.
Is there a reason why you prefer to store the class name instead of the metaclass directly?
There was a problem hiding this comment.
IMO it's good to keep exception types as simple es possible. Having the metaclass directly doesn't add a real benefit. It's just informational and a string should suffice. This makes it easier to introspect/export an exception instance.
bcardiff
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more locations where DB::MappingException is raised and it adds information about the type and property that failed to deserialize.
cf. crystal-lang/crystal#9274