Add workaround for crystal-lang/crystal#9483 #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #159 I found and issue when using it in the actual drivers.
Building the specs of them leads to a:
This seems related to crystal-lang/crystal#9483 which is still open.
The workaround is a safe cast before yielding. The cast is safe because of the return type restriction of
begin_transaction : Transaction
.Unfortunately there is no way to add a spec for this on crystal-db because
DummyDriver
is loaded in the specs.DummyDriver
defines its own custom transaction type and that, somehow, make the compile error go away also. Drivers do not need to define their own transaction.By using a
foo.cr
in the root of crystal-db you can reproduce the issue, as long as DummyDriver is not loaded.Note: there is no FakeDriver defined, and that is fine for this snippet. I was not able to reduce it further.