Close a transaction when returning from within its block

[jgaskins]

If you open a transaction inside a method and return from that method, the transaction remains open. Seems this else doesn't get invoked on a return.

Reproduction:

require "db"
require "pg"
require "log"

# To show that the transaction is never COMMITed nor ROLLBACKed
Log.setup :debug

pg = DB.open("postgres:///")

2.times { do_the_thing pg }

def do_the_thing(pg)
  pg.transaction do |txn|
    rs = txn.connection.exec "select 42"

    return
  end
end

To do this requires an ensure block, but that would also execute alongside every rescue and the else, so instead I just made the rescue blocks flip a bit and the ensure block does the work based on the state of that bit.