Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix positional parameter warnings #173

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

straight-shoota
Copy link
Member

Fixes these warnings for positional parameter mismatches. This warning was introduced in Crystal 1.5.0 (crystal-lang/crystal#11915 crystal-lang/crystal#12167).

In spec/custom_drivers_types_spec.cr:55:34

 55 | def build_prepared_statement(command) : DB::Statement
                                   ^------
Warning: positional parameter 'command' corresponds to parameter 'query' of the overridden method DB::Connection#build_prepared_statement(
query), which has a different name and may affect named argument passing

In spec/custom_drivers_types_spec.cr:59:36

 59 | def build_unprepared_statement(command) : DB::Statement
                                     ^------
Warning: positional parameter 'command' corresponds to parameter 'query' of the overridden method DB::Connection#build_unprepared_statemen
t(query), which has a different name and may affect named argument passing

@straight-shoota straight-shoota merged commit 07c68d3 into master Oct 20, 2022
@straight-shoota straight-shoota deleted the fix/positional-parameter-warnings branch October 20, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants