Add exception cause support to PoolResourceLost
and ConnectionLost
constructors
#199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing database drivers are required to raise a
ConnectionLost
error when they detect an existing connection has gone bad (such as when a firewall or server resets the connection). However the original exception (probablyIO::Error
) is lost. I'd really like to be able to see the original exception (and especially it's stack trace) which caused theConnectionLost
error to be thrown, because it will help diagnose / investigate whatever caused the issue (i.e. it could be caused by a defect in the database driver, rather than a true bad connection).This pull request updates the
PoolResourceLost
(and is inherited toConnectionLost
) constructor to add the missing optionalcause
parameter that is available on the baseException
class.Obviously then it will be up to the database drivers to include the cause when raising
ConnectionLost
.Thanks for your consideration!