Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release connection when query cannot be built #65

Merged
merged 3 commits into from
Sep 8, 2017

Conversation

crisward
Copy link
Contributor

This was leaking connection when a query could not be build - ie if an invalid column name was used.
More info here - crystal-lang/crystal-mysql#40

This was leaking connection when a query could not be build - ie if an invalid column name was used.
More info here - crystal-lang/crystal-mysql#40
@bcardiff
Copy link
Member

bcardiff commented Sep 7, 2017

  • there was some on missing scenario (unprepared statements).
  • there was a tracking on the connection that should not be done (although it was harmless).
  • specs were needed.

@asterite or @RX14 do you want to double check?

@asterite
Copy link
Member

asterite commented Sep 8, 2017

@bcardiff So cool that you added tests for this :-)

@crisward
Copy link
Contributor Author

crisward commented Sep 8, 2017

@bcardiff Thanks, I wouldn't of had a clue on writing tests for this. Looking forward to seeing it merged and deleting my fork.

@bcardiff bcardiff merged commit f4c1c36 into crystal-lang:master Sep 8, 2017
@bcardiff
Copy link
Member

bcardiff commented Sep 8, 2017

Thanks you @crisward for digging and finding the right section for the fix :-).
My apologies for the delay here.

@crisward
Copy link
Contributor Author

crisward commented Sep 8, 2017

@bcardiff That's ok. The nice thing about shards is it's pretty easy to use forks. Everyone finds it difficult to put time in on open source, I'm currently working on an imap library, which at it's current pace should be production ready in maybe 10 - 20 years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants