Support MySQL 8

spec/driver_spec.cr

@@ -12,22 +12,25 @@ describe Driver do
   it "should connect with credentials" do
     with_db do |db|
       db.scalar("SELECT DATABASE()").should be_nil
-      db.scalar("SELECT CURRENT_USER()").should match(/^root@/)
+      db.scalar("SELECT CURRENT_USER()").should match(/^#{database_user}@/)
 
       # ensure user is deleted
-      db.exec "GRANT USAGE ON *.* TO crystal_test IDENTIFIED BY 'secret'"
+      db.exec "DROP USER IF EXISTS crystal_test"
+      db.exec "CREATE USER crystal_test IDENTIFIED WITH mysql_native_password BY 'Secret123!'"
+      db.exec "GRANT USAGE ON *.* TO crystal_test"
       db.exec "DROP USER crystal_test"
       db.exec "DROP DATABASE IF EXISTS crystal_mysql_test"
       db.exec "FLUSH PRIVILEGES"
 
       # create test db with user
       db.exec "CREATE DATABASE crystal_mysql_test"
-      db.exec "CREATE USER crystal_test IDENTIFIED BY 'secret'"
-      db.exec "GRANT ALL PRIVILEGES ON crystal_mysql_test.* TO crystal_test"
+      db.exec "DROP USER IF EXISTS 'crystal_test'@'#{database_host}'"
+      db.exec "CREATE USER 'crystal_test'@'#{database_host}' IDENTIFIED WITH mysql_native_password BY 'Secret123!'"
+      db.exec "GRANT ALL PRIVILEGES ON crystal_mysql_test.* TO 'crystal_test'@'#{database_host}'"
       db.exec "FLUSH PRIVILEGES"
     end
 
-    DB.open "mysql://crystal_test:secret@#{database_host}/crystal_mysql_test" do |db|
+    DB.open "mysql://crystal_test:Secret123!@#{database_host}/crystal_mysql_test" do |db|
       db.scalar("SELECT DATABASE()").should eq("crystal_mysql_test")
       db.scalar("SELECT CURRENT_USER()").should match(/^crystal_test@/)
     end

spec/spec_helper.cr

@@ -4,9 +4,17 @@ require "../src/mysql"
 include MySql
 
 def db_url(initial_db = nil)
-  "mysql://root@#{database_host}/#{initial_db}"
+  "mysql://#{database_user}:#{database_password}@#{database_host}/#{initial_db}"
 end
 
 def database_host
   ENV.fetch("DATABASE_HOST", "localhost")
 end
+
+def database_user
+  ENV.fetch("DATABASE_USER", "root")
+end
+
+def database_password
+  ENV.fetch("DATABASE_PASSWORD", "crystal_mysql_spec")
+end

src/mysql/packets.cr

@@ -65,8 +65,6 @@ module MySql::Protocol
     def write(packet : MySql::WritePacket)
       caps = CLIENT_PROTOCOL_41 | CLIENT_SECURE_CONNECTION | CLIENT_PLUGIN_AUTH_LENENC_CLIENT_DATA
 
-      caps |= CLIENT_PLUGIN_AUTH if @password
-
       caps |= CLIENT_CONNECT_WITH_DB if @initial_catalog
 
       packet.write_bytes caps, IO::ByteFormat::LittleEndian