Skip to content

Commit

Permalink
Fixed #4458: missing location for to_unsafe call
Browse files Browse the repository at this point in the history
  • Loading branch information
@asterite
asterite committed Jun 3, 2017
1 parent d8eac43 commit ddc3cb3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/compiler/crystal/semantic/main_visitor.cr
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2378,7 +2378,7 @@ module Crystal
end
end

unsafe_call = Conversions.to_unsafe(node, Var.new("value"), self, actual_type, expected_type)
unsafe_call = Conversions.to_unsafe(node, Var.new("value").at(node), self, actual_type, expected_type)
if unsafe_call
node.extra = unsafe_call
return
Expand Down

1 comment on commit ddc3cb3

@RX14
Copy link
Contributor

@RX14 RX14 commented on ddc3cb3 Jun 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to be playing whack-a-mole with these debug locations, would it be possible to verify that all nodes have a correct debug locations in crystal code, or somehow enumerate all the places where this has been missed?

Please sign in to comment.