-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update shell.nix
to nixpkgs-24.05
and LLVM 18
#14651
base: master
Are you sure you want to change the base?
Update shell.nix
to nixpkgs-24.05
and LLVM 18
#14651
Conversation
Like in #14592 there are some spec failures in CI related to iconv. |
Apparently Apple replaced the system iconv implementation from an old GNU libiconv to a FreeBSD-based one in 2023, so this is why I recalled not seeing those spec failures on my M2 in the past? The actual bug is somewhat weird, and I have managed to reproduce it in C as well. # first call consumes 1023 bytes and outputs 992 bytes; all the `y`s are lost
# second call consumes 3 bytes and outputs 2 bytes for the `好`
("x" * 992 + "y" * 31 + "好").encode("EUC-JP").size # => 994 |
We should pass either |
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/cross-compiling-crystal-applications-part-2/7090/12 |
Detect if macOS is the compilation target and forces libiconv usage instead of macOS built-in iconv as is broken since 2023. Ref: * crystal-lang/crystal#14651 (comment)
My bad, it's |
Now for some reason CI on macOS doesn't even complete anymore. https://github.com/crystal-lang/crystal/actions/runs/11682308922/job/32535751549?pr=14651 is running for 4 hours now. |
I think I have seen that outside this PR (https://github.com/crystal-lang/crystal/actions/runs/11856091183/job/33041700399), so I think we're fine? |
Without completion of the CI job we cannot be sure the changes in this PR actually work as expected. Also the fact that this hangup reproduces consistently makes me think it is related to the change. |
I tried applying #15150 and I think CI is progressing now: https://github.com/HertzDevil/crystal/actions/runs/11893760288/job/33139453764 |
shell.nix
to nixpkgs-24.05
shell.nix
to nixpkgs-24.05
and LLVM 18
@HertzDevil That seems to have resolved it. So this is ready for review now. We can probably update to nixpkgs 24.11 soon. |
Updates nixpkgs in
shell.nix
to 24.05 release. This release also brings LLVM 18 (and drops LLVM 11) so we update LLVM as well.Closes #14269, #14592