-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Crystal::System::Addrinfo
#14957
Add Crystal::System::Addrinfo
#14957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about moving the yielding getaddrinfo(&)
as a system method? That would abstract the next/free logic.
thought: Maybe |
thought: I'm wondering if it really makes sense to split the |
Don't worry, |
So the plan is to switch entirely to |
My intent was for the system API to be the yielding |
Moves the platform-specific code into a separate module, so that implementations other than
LibC.getaddrinfo
can be added without cluttering the same file (e.g. Win32'sGetAddrInfoExW
from #13619). Depends on #14956.