Fix failing specs on FreeBSD #15093
Merged
Fix failing specs on FreeBSD #15093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+22
to
+24
| # can't use SIGUSR1/SIGUSR2 on FreeBSD because Boehm uses them to suspend/resume threads | ||
| signal1 = {% if flag?(:freebsd) %} Signal.new(LibC::SIGRTMAX - 1) {% else %} Signal::USR1 {% end %} | ||
| signal2 = {% if flag?(:freebsd) %} Signal.new(LibC::SIGRTMAX - 2) {% else %} Signal::USR2 {% end %} |
There was a problem hiding this comment.
question: Could we use RT signals on all platforms, instead of USR1, USR2?
There was a problem hiding this comment.
Maybe, though I'm not sure all platforms have SIGRT signals, and USR1 and USR2 should usually be available ... I wonder why would Boehm use USR1 and USR2 when it can use SIGRT signals (and does so, but only when told to) 🤷
straight-shoota
approved these changes
Oct 18, 2024
straight-shoota
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.