Support dereferencing symlinks in make install
#15138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose this could be fine as a quick fix for installation. But symlinks in the repo itself are still unusable. I'm fine with merging this as a temporary measure though. |
|
You could share a Crystal Git repository that is created outside MSYS2, but |
straight-shoota
approved these changes
Oct 30, 2024
straight-shoota
changed the title
make installmake install
CTC97
pushed a commit
to CTC97/crystal
that referenced
this pull request
Nov 9, 2024
On platforms without complete symbolic link support (e.g. native MSYS2 environments), `make install deref_symlinks=1` will dereference the individual directories under `src/lib_c` and copy the contents, instead of copying the directories as symbolic links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On platforms without complete symbolic link support (e.g. native MSYS2 environments),
make install deref_symlinks=1will dereference the individual directories undersrc/lib_cand copy the contents, instead of copying the directories as symbolic links.