Implement the ARM64 Windows context switch #15155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:feature
topic:stdlib:concurrency
platform:windows
|
Aside question: is there any reason to keep supporting LLVM 9? Especially for AArch64 where we recommend to use at least LLVM 13? Edit: even Crystal 1.0 was released with LLVM 10 it seems (at least on Linux). |
|
Before we switched to the current AArch64 CI images, the previous ones actually used LLVM 8 |
straight-shoota
approved these changes
Nov 5, 2024
straight-shoota
pushed a commit
that referenced
this pull request
Nov 7, 2024
Tested using a Windows VM on an Apple M2 host. The instructions we use in our MinGW-w64 CI workflow will just work by simply replacing `-ucrt-` in the MSYS2 package names with `-clang-aarch64-`. Requires #15155 on both the cross-compilation host and the target.
CTC97
pushed a commit
to CTC97/crystal
that referenced
this pull request
Nov 9, 2024
This is essentially the existing AArch64 context switch, plus the Win32-specific Thread Information Block handling. It makes specs like `spec/std/channel_spec.cr` pass, and the compiler macro run also depends on it.
CTC97
pushed a commit
to CTC97/crystal
that referenced
this pull request
Nov 9, 2024
…#15159) Tested using a Windows VM on an Apple M2 host. The instructions we use in our MinGW-w64 CI workflow will just work by simply replacing `-ucrt-` in the MSYS2 package names with `-clang-aarch64-`. Requires crystal-lang#15155 on both the cross-compilation host and the target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #14911. This is essentially the existing AArch64 context switch, plus the Win32-specific Thread Information Block handling. It makes specs like
spec/std/channel_spec.crpass, and the compiler macro run also depends on it.