Add String#to_utf16 and String.from_utf16 #5541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/string/utf16.cr
Outdated
| elsif ord >= 0x10000 | ||
| # Needs surrogate pair | ||
| ord -= 0x10000 | ||
| slice[i] = 0xd800_u16 + ((ord >> 10) & 0x3ff) # Keep top 10 bytes |
There was a problem hiding this comment.
Thanks, fixed (did amend)
RX14
approved these changes
Jan 5, 2018
spec/std/string/utf16.cr
Outdated
| @@ -0,0 +1,47 @@ | |||
| require "spec" | |||
RX14
previously approved these changes
Jan 5, 2018
Sija
reviewed
Jan 5, 2018
src/string/utf16.cr
Outdated
| # unicode replacement char value `0xfffd`. | ||
| # | ||
| # ``` | ||
| # UTF16.encode("hi 𐂥") # => Slice[104_u16, 105_u16, 32_u16, 55296_u16, 56485_u16] |
There was a problem hiding this comment.
UTF16.encode("hi 𐂥") => "hi 𐂥".to_utf16
There was a problem hiding this comment.
thanks, I forgot to update the docs
RX14
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful to interface with Windows functions that expect/return UTF-16 values.