Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.26.0 #6475

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Release 0.26.0 #6475

merged 1 commit into from
Aug 9, 2018

Conversation

bcardiff
Copy link
Member

@bcardiff bcardiff commented Aug 1, 2018

Preview at https://github.com/bcardiff/crystal/blob/changelog/0.26.0/CHANGELOG.md

Note: I still need to convert PR references to links and there are a couple of PR to be merged before this.

CHANGELOG.md Outdated
### Formatter

- Fixed formatting of `{ {1}.foo, ...}` like expressions. ([#6300], thanks @asterite)
- Fixed formatting of when with numbers. Use right alignment only if all are number literals. ([#6392], thanks @MakeNowJust)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when in backticks

CHANGELOG.md Outdated

### Macros

- Add `pp!` and `p!` macro methods. ([#6374], thanks @straight-shoota)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this change lies in the standard library section, as you can't add or change the available macro methods

Copy link
Member

@straight-shoota straight-shoota Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. But macros are also documented in stdlib API. I'm not sure about this.

But it reminds me that I actually forgot adding docs for p! and pp! in that PR :o

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll move it to language changes. Macro methods are defined in the language itself at the end of the day. But I will keep a Macros subsection for that.

CHANGELOG.md Outdated
- Fixed compilation issue when running spec against compiler and std together. ([#6312], thanks @straight-shoota)
- Add support for llvm 6.0. ([#6381], [#6380], [#6383], thanks @felixbuenemann)
- CI improvements and housekeeping. ([#6313], [#6337], [#6407], [#6408] thanks @bcardiff, @MakeNowJust, @r00ster91)
- Flatten project structure created by crystal init. ([#6317], thanks @straight-shoota)
Copy link
Member

@straight-shoota straight-shoota Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this belong to Tools? And backticks... ;)

@straight-shoota
Copy link
Member

I think the last two changes belong to Standard Library. And maybe mention that #6333 also added an optional argument to String#check_no_null_byte.

CHANGELOG.md Outdated

- Fixed `system_spec` does no longer emit errors messages on BSD platforms. ([#6289], thanks @jcs)
- Fixed compilation issue when running spec against compiler and std together. ([#6312], thanks @straight-shoota)
- Add support for llvm 6.0. ([#6381], [#6380], [#6383], thanks @felixbuenemann)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLVM is normally in uppercase

CHANGELOG.md Outdated
- CI improvements and housekeeping. ([#6313], [#6337], [#6407], [#6408] thanks @bcardiff, @MakeNowJust, @r00ster91)
- Flatten project structure created by crystal init. ([#6317], thanks @straight-shoota)
- Refactor platform specifics from `ENV` to `Crystal::System::Env` and implement for windows. ([#6333], thanks @straight-shoota)
- Add support for `WinError` UTF16 string messages. ([#6442], thanks @straight-shoota)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UTF-16 with a dash is the standard naming, to be consistent with the UTF-8 written above

CHANGELOG.md Outdated
- **(breaking-change)** Constant lookup context in macro is now lexical. ([#5354], thanks @MakeNowJust)
- **(breaking-change)** Evaluate instance var initializers at the metaclass level (ie: disallow using `self`). ([#6414], thanks @asterite)
- Add `&+` `&-` `&*` `&**` operators parsing. NB: No behaviour is assigned to these operators yet. ([#6329], thanks @bcardiff)
- Add support for empty `case` without `when`. ([#6367], thanks @straight-shoota)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could precise the main purpose of this: ... "to generate them with macros"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An explanation for any change can be found in the respective PRs. It's unnecessary to mention here.

@RX14 RX14 added this to the 0.26.0 milestone Aug 2, 2018
@jkthorne
Copy link
Contributor

jkthorne commented Aug 3, 2018

Are there still concerns about this PR?
#6358

@hanyuone
Copy link

hanyuone commented Aug 3, 2018

Is #6419 going to be included in 0.26.0 or is that going to have to wait until the next release?

CHANGELOG.md Outdated

### Text

- **(breaking-change)** `String#from_utf-16(pointer : Pointer(UInt16))` returns now `{String, Pointer(UInt16)}`. ([#6333], thanks @straight-shoota)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One grep to much ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I missing something or you are pointing the fact that is was duplicated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String#from_utf16

CHANGELOG.md Outdated
- Add support for LLVM 6.0. ([#6381], [#6380], [#6383], thanks @felixbuenemann)
- CI improvements and housekeeping. ([#6313], [#6337], [#6407], [#6408], [#6315], thanks @bcardiff, @MakeNowJust, @r00ster91, @maiha)
- Refactor platform specifics from `ENV` to `Crystal::System::Env` and implement for windows. ([#6333],
- Add an optional argument to `String#check_no_null_byte.thanks @straight-shoota`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is already listed in Text, but the one above misses the attribution.

CHANGELOG.md Outdated

- Fixed `Socket#accept?` base implementation. ([#6277], thanks @ysbaddaden)
- Fixed performance issue due to unbuffered `IO` read. `IO#sync` only affect writes, introduce `IO#read_buffering?`. ([#6304], [#6474], thanks @asterite, @bcardiff)
- Fixed hanlding of closed state in `HTTP::Server::Response`. ([#6477], thanks @straight-shoota)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"handling"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did the spell checker turned off? 😅

CHANGELOG.md Outdated
## Language changes

- **(breaking-change)** Revert do not collapse unions for sibling types. ([#6351], thanks @asterite)
- **(breaking-change)** Restrict `exp.@var` to types in the same hierarchy. ([#6358], thanks @asterite)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due recent revert #6484, this is no longer true 😢

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, but don't be sad :-).

FYI, We are waiting a couple of more PR and small fixes before a final round on the changelog is done and the release process begin.

@hanyuone
Copy link

hanyuone commented Aug 7, 2018

Windows should be uppercase, not lowercase.

@bcardiff bcardiff force-pushed the changelog/0.26.0 branch 2 times, most recently from 9ed079a to 3480f68 Compare August 9, 2018 04:41
@bcardiff bcardiff changed the title [WIP] Release 0.26.0 Release 0.26.0 Aug 9, 2018
@bcardiff bcardiff force-pushed the changelog/0.26.0 branch 2 times, most recently from 421f7e1 to ecd5bd1 Compare August 9, 2018 13:54
@bcardiff bcardiff merged commit eeb53c5 into crystal-lang:master Aug 9, 2018
@bcardiff bcardiff deleted the changelog/0.26.0 branch August 9, 2018 16:45
@wdhwg001
Copy link

wdhwg001 commented Aug 9, 2018

And Unicode should not be unicode maybe?

@bcardiff
Copy link
Member Author

bcardiff commented Aug 9, 2018

@wdhwg001 it was, but I double check with in other places in docs and lower case was used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants