Change IO#write, IO#skip, IO.copy to return Int64 #9363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Int64
instead ofUInt64
.IO.copy
to returnInt64
for consistencyIO::Stapled#write_byte
,String::Builder#write_byte
which were missing in Make IO#skip IO#write returns the number of bytes it skipped/written #9233.The dilema between using UInt64 or Int64 was due to:
LibC.write
returned unsigned, but I was wrong 🤷♂️. I know we are not using the turned value directly inIO#write
, but they are related.IO.copy
But since mixing signed and unsigned types will impose some performance issues, we can avoid them if we discourage unsigned int in some cases like this one.