Compiler: show warnings even if there are errors #9461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9460
Now warnings are shown even if there are errors.
I also cleaned up the code so that warnings are reported in the semantic phase, not the in the codegen phase.
Now this snippet:
Gives this error:
You can see that the warning tells you that the return type is wrong, which then connects to the error below.
If you want to fix this is another way, let me tell you that it's impossible. The idea is that abstract method errors must kick before the semantic phase, but right now they are warnings so that's impossible to do. The real solution is to make those warning be errors, but first #8766 and #8232 (which is not a bug to me, the user should define the exact method that's wanted, and later they can do a dispatch if they want) must be fixed.