Fix E notation parsing in BigDecimal
#9577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 6, 2020
straight-shoota
approved these changes
Dec 30, 2020
|
Apologies for the long delay on this... I will review if still relevant and fix up PR if needed (else close) |
stevegeek
force-pushed
the
fix_e_notation_big_decimal
branch
from
345fc96
to
f40b0ef
Compare
|
I can confirm this (#9547) is still an issue , and this fix is still relevant. My RFC for changing the parsing: #9580 #9581 is also thus still relevant but guess it maybe superseeded by #10641 .. anyway will move that discussion there. Thank you @beta-ziliani for all the work on Crystal (and thanks @straight-shoota for the original review)! Let me know if there is anything else you need with this PR. |
straight-shoota
approved these changes
Mar 11, 2022
straight-shoota
changed the title
BigDecimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9547
These changes fix the various classes of problems i could find by fuzzing the passing of E notation in
BigDecimal