Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new search path algorithm #123

Closed
2 tasks done
ysbaddaden opened this issue Sep 23, 2016 · 4 comments · Fixed by #127
Closed
2 tasks done

Integrate new search path algorithm #123

ysbaddaden opened this issue Sep 23, 2016 · 4 comments · Fixed by #127
Milestone

Comments

@ysbaddaden
Copy link
Contributor

ysbaddaden commented Sep 23, 2016

We must follow the search patch changes of crystal-lang/crystal#2788. This is a breaking change; projects will have to run rm -rf libs; shards install in their projects for the new dependencies to be installed correctly.

  • install dependencies in lib instead of libs;
  • install dependencies as a whole (not merely the src folder).
@ysbaddaden ysbaddaden added this to the v0.7.0 milestone Sep 23, 2016
@ysbaddaden ysbaddaden changed the title Integrate with new search path algorithm Integrate new search path algorithm Sep 23, 2016
@ysbaddaden
Copy link
Contributor Author

This is blocking #95 (and possibly #110) from being implemented, since the bin folder of dependencies isn't available.

@RX14
Copy link
Contributor

RX14 commented Sep 23, 2016

Should shards detect the old libs format and delete it before install? Have a marker file? Is that too much work for little gain?

@ysbaddaden
Copy link
Contributor Author

Maybe print a message? Maybe have shards prune remove it? Or ask for permission? I'm never comfortable deleting files on someone's computer...

@RX14
Copy link
Contributor

RX14 commented Sep 23, 2016

Maybe print a message saying it's in the old format and must be removed, then exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants