Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make touch shard.lock when SHARDS=false #667

Conversation

straight-shoota
Copy link
Member

The shard.lock recipe doesn't touch the target if SHARDS=false when bootstrapping by downloading lib/molinillo with curl.
This means shard.lock can be considered outdated, even though its up to date.

Ref crystal-lang/distribution-scripts#330 (comment)

@straight-shoota straight-shoota added this to the 0.20.0 milestone Jan 30, 2025
@straight-shoota straight-shoota merged commit ec84197 into crystal-lang:master Feb 3, 2025
9 checks passed
@straight-shoota straight-shoota deleted the infra/fix-make-shard-lock branch February 3, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants