Change get_global_offset_from_line to also take an optional character position #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, crytic-compile has a function to take a source file offset and convert it into line and character position numbers. To reverse this operation,
get_global_offset_from_line
could be used, but it only takes a line number, not a character position number.This PR adds an optional character position parameter which can be used to specify a position on a line number which we want to obtain a source offset for.
It also renames
get_global_offset_from_line
toget_global_offset_from_line_and_character
andget_line_from_offset
intoget_line_and_character_from_offset
for clarity.