Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 20 byte address for --compile-libraries and raise error if argument is invalid #477

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

0xalpharush
Copy link
Contributor

@0xalpharush 0xalpharush commented Jul 27, 2023

Allow 20 byte address for --compile-libraries and raise error if argument is invalid

Fixes #476

xref crytic/echidna#651

@hellwolf
Copy link

I can make a local build next week to test it if it helps.

@0xalpharush 0xalpharush changed the title raise error if compile libraries argument does not yield matches Allow 20 byte address for --compile-libraries and raise error if argument is invalid Aug 7, 2023
@hellwolf
Copy link

hellwolf commented Aug 7, 2023

Thank you! I just tested this right away:

$ /home/hellwolf/Projects/NixOS/nixpkgs.worktree/local-echidna/result/bin/crytic-compile . --compile-force-framework=foundry --foundry-out-directory=build/foundry/out --compile-libraries "(SlotsBitmapLibrary,0xf01),(SuperfluidLoaderLibrary,0xf02),(SuperfluidPoolDeployerLibrary,0xf03),(CFAv1ForwarderDeployerLibrary,0xf11),(GDAv1ForwarderDeployerLibrary,0xf12),(IDAv1ForwarderDeployerLibrary,0xf13),(ProxyDeployerLibrary,0xf14),(SuperfluidCFAv1DeployerLibrary,0xf15),(SuperfluidFlowNFTLogicDeployerLibrary,0xf16),(SuperfluidGDAv1DeployerLibrary,0xf17),(SuperfluidGovDeployerLibrary,0xf18),(SuperfluidHostDeployerLibrary,0xf19),(SuperfluidIDAv1DeployerLibrary,0xf1a),(SuperfluidLoaderDeployerLibrary,0xf1b),(SuperfluidPeripheryDeployerLibrary,0xf1c),(SuperfluidPoolLogicDeployerLibrary,0xf1d),(SuperfluidPoolNFTLogicDeployerLibrary,0xf1e),(SuperTokenDeployerLibrary,0xf1f),(TokenDeployerLibrary,0xf20)" --print-libraries | grep -Eo '__\$[a-z0-9]+' | sort -n
INFO:CryticCompile:'forge clean' running (wd: /home/hellwolf/Projects/superfluid/protocol-monorepo.worktree/update_nix_flake_inputs/packages/hot-fuzz)
INFO:CryticCompile:'forge build --build-info' running (wd: /home/hellwolf/Projects/superfluid/protocol-monorepo.worktree/update_nix_flake_inputs/packages/hot-fuzz)
__$29bfd6d2f1b844495450d685faea9e543e
__$29bfd6d2f1b844495450d685faea9e543e

It seems only one hole left, and it may well be that I haven't specified it myself.

Edit:

Yep: it was me.

So this fix works!

@0xalpharush 0xalpharush added this pull request to the merge queue Aug 8, 2023
Merged via the queue into dev with commit ef7173b Aug 8, 2023
@0xalpharush 0xalpharush deleted the fix/compile-libraries-validation branch August 8, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants