Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gasuse.sol test is flaky #464

Closed
elopez opened this issue Jun 4, 2020 · 2 comments
Closed

gasuse.sol test is flaky #464

elopez opened this issue Jun 4, 2020 · 2 comments
Labels
performance

Comments

@elopez
Copy link
Member

elopez commented Jun 4, 2020

When running stack test several times, gasuse.sol fails randomly.

...
    basic/darray-mutation.sol:             OK (3.69s)
    basic/gasuse.sol:                      FAIL (27.83s)
      src/test/Common.hs:63:
      g gas estimate wrong
    coverage/boolean.sol:                  OK (5.88s)
...
@incertia
Copy link
Contributor

incertia commented Jun 4, 2020

we can always relax the gas estimate a bit, but there is currently no way to specifically target for gas usage and we simply report the max gas that was seen during the campaign.

@MatthewARinehart MatthewARinehart added this to the Q3 2020 (Version TBD) milestone Aug 12, 2020
@elopez elopez mentioned this issue Jan 26, 2021
Merged
@arcz arcz removed this from the Q3 2020 (Version TBD) milestone Jan 16, 2023
@arcz
Copy link
Member

arcz commented Feb 24, 2023

It's been quite stable for some time already.

@arcz arcz closed this as completed Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MatthewARinehart @incertia @elopez @arcz