Run echidna tests in parallel #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been fixed upstream by GitHub.
Currently the tar.gz file has several folders inside from where the binary used to be in the runner, clean those up using -C.
This helps in the case of CI, and allows to run the tests on a separate container without having to set up any library or Haskell dependencies.
This allows for parallel execution of the echidna tests, which helps improve testing speed, especially once newer solc versions are included in the pipeline.
elopez
force-pushed
the
parallel-testing
branch
from
3aa2f15 to
8fb6371
Compare
|
@ggrieco-tob I've rebased on that PR and it looks like it works fine 👍 I noticed on a personal run that |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements parallel execution of the echidna tests on Actions,
which improves testing speed, especially once several solc versions
are added to the test matrix.
The main drawback is that test execution now waits for both Mac and
Linux builds to finish, because they are both part of the same job. As
far as I could see, there is no way to depend on a specific matrix
combination of a job. A possible solution would be to duplicate the
job, and have different ones for Mac and Linux, instead of using
a build matrix.
The testing system could also use an extra feature to specify a range
of solc versions that a test is good for. There are currently some tests
in the suite with hardcoded versions (i.e. with something like
cryticArgs: ["--solc", "solc-x.y.z"]in the corresponding .yml).I saw an attempt at something like that in #383, but I think it should be
something more flexible using e.g.
Data.SemVer, to allow for fewerversion number hardcoding.
Resolves #563