Save corpus continuously while fuzzing #1047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samalws-tob
force-pushed
the
saveCoverageEarly2
branch
from
ac34896 to
b849924
Compare
arcz
reviewed
May 18, 2023
|
|
||
| -- save to corpus in the background while tests are running | ||
| -- returns a channel that gets sent () when the process is done | ||
| runCorpusSaver :: Env -> IO (Chan ()) |
There was a problem hiding this comment.
can we use MVar instead of Chan here?
There was a problem hiding this comment.
Is there a way to wait for MVar to be written to without doing an infinite loop? I used a Chan because you can wait for it using readChan instead of getting locked in a while (thead is not finished) loop
| nworkers :: Int | ||
| nworkers = fromIntegral $ fromMaybe 1 env.cfg.campaignConf.workers | ||
|
|
||
| loop !dir !chan !workersAlive = when (workersAlive > 0) $ do |
There was a problem hiding this comment.
we have some logic duplication here but we can refactor this with the subscribe system we talked about
There was a problem hiding this comment.
Separate PR for that subscribe system? I could add it to this PR if you want
samalws-tob
force-pushed
the
saveCoverageEarly2
branch
from
b849924 to
0bd1450
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a process which continuously saves corpus as new coverage/reproducers are discovered (#1045). This makes echidna crashes less inconvenient, and shortens the corpus saving time at the end.
It also makes the NewCoverage event include the list of transactions as part of the event, since this is needed when saving corpus info.