-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multicore #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcz
force-pushed
the
multicore
branch
2 times, most recently
from
April 11, 2023 16:35
bc482a0
to
56ca072
Compare
arcz
force-pushed
the
multicore
branch
7 times, most recently
from
April 19, 2023 11:46
bab2f7f
to
f09c7da
Compare
arcz
force-pushed
the
multicore
branch
10 times, most recently
from
April 26, 2023 19:23
6435ec6
to
f184321
Compare
arcz
force-pushed
the
multicore
branch
3 times, most recently
from
April 27, 2023 23:12
937b210
to
736a26c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test, add
--workers N
toechidna
command orworkers: N
to config.This PR also adds
--timeout <seconds>
to CLI which was available only from the yaml config.Notable code changes:
Campaign
type is nowWorkerState
with less data. Tests, coverage and corpus are nowIORef
s that live inEnv
and the data is shared between all workers. The contention on this data is minimal as modifications rarely happen besides the very beginning when coverage grows rapidly.Things to think about:
At the moment, all workers replay the corpus but this is redundant work. Either split corpus across workers to replay or replay it first and then start workers. Consider calls to external contracts that might not be yet deployed. Relevant Show a proper error message when an invalid corpus is used #1008Corpus is now chunked and distributed across workers to replay.Large
test with aworkerId
that falsified the test and only this worker shrinks the test.Closes #476