-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: call constant methods occasionally and allow assertion testing them #363
Conversation
This will also close #55 but I'm not sure about it's last requirement
This can be left for later work, if desired, but I don't followed why we'd special case the last call. cc @Xenomega |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks really good. The only concern is that I don't think your test case is being called at the moment.
Additionally, I'm thinking if we move the TestViewMethods
config variable outside of the AssertionTesting
structure and put it in Testing
. I'm thinking that testing view methods as a concept is more general than assertion testing or property testing. So maybe, we just push it up one level in the hierarchy. what do you think?
fuzzing/testdata/contracts/assertions/assert_constant_method.sol
Outdated
Show resolved
Hide resolved
I understand this config to mean that assertion failures in constant methods will be treated as failure if assertion mode is enabled, but I see your point that this will affect the sequences generated for property mode as well. I suppose we could have We could capture this in an issue and decide this after merging and implementing filtering ( I want to replace #275 to be compatible with these changes and fix several bugs in its implementation) |
Yeah I think this is fine for now and we can figure this out later |
…them (#363) * feat: call constant methods ocassionally and allow assertion testing them * add test
closes #168