Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check that receipt is non-nil in OnTxEnd hook #457

Merged
merged 2 commits into from
Aug 27, 2024
Merged

fix: check that receipt is non-nil in OnTxEnd hook #457

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c799f08
throw panic if execution tracing fails
anishnaik Aug 23, 2024
c5cd36a
do not store trace in case of error
anishnaik Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions fuzzing/executiontracer/execution_tracer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,12 @@ func (t *ExecutionTracer) GetTrace(txHash common.Hash) *ExecutionTrace {

// OnTxEnd is called upon the end of transaction execution, as defined by tracers.Tracer.
func (t *ExecutionTracer) OnTxEnd(receipt *coretypes.Receipt, err error) {
// We avoid storing the trace for this transaction. An error should realistically only occur if we hit a block gas
// limit error. In this case, the transaction will be retried in the next block and we can retrieve the trace at
// that time.
if err != nil || receipt == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if err != nil || receipt == nil {
if receipt == nil {

I don't think we need to check both but I will merge as is

return
}
t.traceMap[receipt.TxHash] = t.trace
}

Expand Down