Improve parsing of contract's comment #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #1677, right? |
|
Yes, I actually did not notice #1667 :) |
0xalpharush
reviewed
Mar 10, 2023
| # the initial space (after *) is also not kept on every line | ||
| comments = "@title Test Contract\n@dev Test comment" | ||
| solc_select.switch_global_version("0.5.16", always_install=True) | ||
| slither = Slither("./tests/custom_comments/contract_comment.sol") |
There was a problem hiding this comment.
Is this meant to test the compact AST or should solc_force_legacy_json be used?
There was a problem hiding this comment.
It was not meant to test the legacy AST, the compact AST itself changed regarding the comment information. However I added an additional test for the legacy AST 7aba140
0xalpharush
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.