Detector for ecrecover return value validation and use of nonces #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump version
readme updates for 0.9.4 release
Align with dev
Revert formatting change
Revert formatting change
Revert formatting change
0xalpharush
reviewed
Jun 30, 2023
Comment on lines
+132
to
+138
| if SolidityFunction("keccak256(bytes)") in node.solidity_calls: | ||
| for ir in node.irs: | ||
| if isinstance(ir, SolidityCall) and ir.function == SolidityFunction( | ||
| "keccak256(bytes)" | ||
| ): | ||
| if "nonce" not in str(ir.expression): | ||
| nonce_results.append(node) |
There was a problem hiding this comment.
Some APIs will require that a hash is passed in and I think this would cause FPs. You may have to explore all paths starting from functions_entry_points and find the union of values not hashed but passed to ecrecover
There was a problem hiding this comment.
Like this
slither/slither/detectors/statements/msg_value_in_loop.py
Lines 13 to 31 in 3d4f934
0xalpharush
reviewed
Jun 30, 2023
Comment on lines
+100
to
+110
| def _zero_address_validation(var: LocalVariable, function: Function) -> bool: | ||
| for node in function.nodes: | ||
| if node.contains_if() or node.contains_require_or_assert(): | ||
| for ir in node.irs: | ||
| expression = str(ir.expression) | ||
| if isinstance(ir, Binary) and str(var) in expression: | ||
| if ( | ||
| ir.type == BinaryType.NOT_EQUAL or ir.type == BinaryType.EQUAL | ||
| ) and "address(0)" in expression: | ||
| return True | ||
| return False |
There was a problem hiding this comment.
Not sure if it's helpful but there were some improvements desired in the missing-zero-check outlined in #1544 that may be relevant here
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used #1516 as a starting point, related to issue #1950
Detects the usage of ecrecover and checks if the signer address is validated against the zero address.
If a function uses ecrecover, checks if a nonce is present in any of the hashes.
Currently does so via string comparisons and naively checks any hash for a nonce, so it could have a lot of FPs