-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use snapshot based tests for printers #2416
base: dev
Are you sure you want to change the base?
Conversation
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 247 files out of 300 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Known errorsknown_failures = {
all_printers.Halstead: [
"top_level_variable-0.8.0.sol-0.8.12-compact.zip",
"top_level_variable2-0.8.0.sol-0.8.12-compact.zip",
"custom_error_with_state_variable.sol-0.8.12-compact.zip",
],
all_printers.PrinterSlithIRSSA: [
"*",
],
} For the For the SlithIR SSA printer, the problem is that the SSA assignment is not stable : two different runs on the same file will not output the same IR because some variables name may change. |
@0xalpharush any idea on how to handle the EVM CFG printer ? Should we keep a test in the CI or add the missing dependency to the new test case ? |
Let's just keep the EVM printer in the existing bash script |
# Conflicts: # tests/e2e/printers/test_printers.py
Right now, the printers are only run in the CI but their results is not checked.
This PR moves the system to use snapshot based results, like it is done for detectors.
Remaining TODO