Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xtermjs and socketio #18

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Update xtermjs and socketio #18

merged 2 commits into from
Aug 11, 2021

Conversation

manics
Copy link
Contributor

@manics manics commented May 1, 2021

Thanks for creating this project as a learning resource. I thought I'd update the dependencies:

  • xterm 4.11.0
  • socket.io 4.0.1
  • flask-socketio 5

manics added 2 commits May 1, 2021 16:47
- xterm 4.11.0
- socket.io 4.0.1
- flask-socketio 5
<script src="https://unpkg.com/xterm@3.6.0/dist/xterm.js"></script>
<script src="https://unpkg.com/xterm@3.6.0/dist/addons/fit/fit.js"></script>
<script src="https://unpkg.com/xterm@3.6.0/dist/addons/webLinks/webLinks.js"></script>
<script src="https://unpkg.com/xterm@3.6.0/dist/addons/fullscreen/fullscreen.js"></script>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fullscreen addon is no longer supported

@cs01
Copy link
Owner

cs01 commented May 20, 2021

Thanks for this! It will definitely be good to keep the "bit rot" off this as much as possible.

I tried it out with

python3.7 -m venv venv
source venv/bin/activate
pip install -r requirements.txt 
python -m pyxtermjs

but in the browser, the state remains on "connecting" and the terminal doesn't work. Could you provide steps to reproduce it working?

@cs01 cs01 self-requested a review May 20, 2021 05:47
Copy link
Owner

@cs01 cs01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not get this branch to run in my computer

@manics
Copy link
Contributor Author

manics commented Jun 3, 2021

Sorry for the delay in responding. I've tested this again just now:

conda create -n tmp python=3.7
conda activate tmp
pip install -r requirements.txt 
pip install .
python -m pyxtermjs

http://127.0.0.1:5000/ loads successfully. I've tried this in Firefox 88.0 and Chrome 90.0.4430.93 on Fedora Linux 33.

@cs01
Copy link
Owner

cs01 commented Aug 11, 2021

Sorry for the delay in responding.

I too am sorry for my delayed reply :). I tried out your change again, and it worked. I think the fix is to update setup.py to install from requirements.txt. I'll merge your change as-is and then fix setup.py some more.

@cs01 cs01 merged commit 8cc4fb2 into cs01:master Aug 11, 2021
@manics manics deleted the update-deps branch August 11, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants