-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update xtermjs and socketio #18
Conversation
- xterm 4.11.0 - socket.io 4.0.1 - flask-socketio 5
<script src="https://unpkg.com/xterm@3.6.0/dist/xterm.js"></script> | ||
<script src="https://unpkg.com/xterm@3.6.0/dist/addons/fit/fit.js"></script> | ||
<script src="https://unpkg.com/xterm@3.6.0/dist/addons/webLinks/webLinks.js"></script> | ||
<script src="https://unpkg.com/xterm@3.6.0/dist/addons/fullscreen/fullscreen.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fullscreen addon is no longer supported
Thanks for this! It will definitely be good to keep the "bit rot" off this as much as possible. I tried it out with
but in the browser, the state remains on "connecting" and the terminal doesn't work. Could you provide steps to reproduce it working? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could not get this branch to run in my computer
Sorry for the delay in responding. I've tested this again just now:
http://127.0.0.1:5000/ loads successfully. I've tried this in Firefox 88.0 and Chrome 90.0.4430.93 on Fedora Linux 33. |
I too am sorry for my delayed reply :). I tried out your change again, and it worked. I think the fix is to update |
Thanks for creating this project as a learning resource. I thought I'd update the dependencies: